mirror of
https://github.com/game-ci/unity-builder.git
synced 2026-05-31 13:56:13 -07:00
* chore: quality-tightening (oxfmt + oxlint + tsc + vitest + husky + actionlint)
Standard rollout for unity-builder. Most of the work was porting 24
test files from jest 27 to vitest 4.
- prettier -> oxfmt
- eslint (with @typescript-eslint, github, jest, prettier, unicorn) ->
oxlint with eslint-plugin-unicorn
- jest 27 + jest-circus + ts-jest + @types/jest + @jest/globals ->
vitest 4 + vite 7 + @vitest/coverage-istanbul (jest config files
removed)
- new: tsgo --noEmit (alongside tsc fallback)
- lefthook (and lefthook.yml) -> husky 9 with the standard
scripts/ensure-husky.mjs self-heal pattern + lint-staged
- new: gitleaks, actionlint, shellcheck as mise-managed binaries
- TypeScript bumped target ES2020 -> ES2022 + lib ES2022 + DOM (for
Error.cause and modern globals)
Test migration (24 files):
- Bulk-converted jest.* -> vi.*; jest.Mocked -> Mocked from vitest;
jest.MockedFunction -> MockedFunction.
- Added vitest imports to all *.test.ts files (and __mocks__/*.ts)
that didn't have them.
- src/index.ts: extracted runMain() as a named export and gated the
module-level invocation behind NODE_ENV !== 'test'. The
index-plugin-features test now calls runMain() directly instead of
relying on jest's removed vi.isolateModules.
- index-plugin-features.test.ts: moved hoisted refs (mockPlugin,
mockLoadOrchestratorPlugin) into vi.hoisted() so vi.mock factories
can reference them. Replaced arrow constructor mock for ImageTag
with regular function() {...} (vitest 4 disallows arrows as ctors).
Replaced require('./model') / require('@actions/core') inside test
bodies with top-level imports.
- model/orchestrator-plugin.test.ts: dropped jest's '{ virtual: true }'
flag (vitest doesn't support it); replaced the
'mock factory throws' pattern with 'createPlugin throws' so vitest
doesn't wrap the error message at the assertion site.
- model/versioning.test.ts: stray jest.spyOn -> vi.spyOn; replaced
mockImplementation() with no args (jest pattern) by
mockResolvedValue('') / mockImplementation(() => undefined) where
the source expects a string return.
Workflow shell-quoting cleanup (actionlint):
- All bare $GITHUB_STEP_SUMMARY / $GITHUB_OUTPUT / $GITHUB_ENV
redirects quoted across 2 workflows (SC2086).
- s3://$AWS_STACK_NAME / s3://$BUCKET_NAME -> s3://"$AWS_STACK_NAME"
/ s3://"$BUCKET_NAME".
- 'for i in {1..N}; do ... done' loops where i isn't referenced in
the body renamed to 'for _ in' (SC2034).
- 'grep ... | wc -l' -> 'grep -c ...' (SC2126).
- Multiple consecutive '>> $file' redirects in
validate-community-plugins.yml summary block collapsed into a
single block redirect (SC2129).
- 'cat $file | python3 -c "..."' -> 'python3 -c "..." < $file'
(SC2002).
- http://${VAR}:port -> http://"${VAR}":port (SC2086).
tsgo: kept tsc --noEmit as the default 'typecheck' because
unity-builder publishes CommonJS for the GitHub Action consumer,
which conflicts with tsgo's bundler/node16 moduleResolution
requirement (per playbook trap #9). 'yarn typecheck:tsgo' is wired
up for when consumers move to ESM.
Caveats: 28 pre-existing oxlint warnings remain (mostly
typescript/no-explicit-any across the build-parameter shapes and
vitest/no-disabled-tests on 2 explicitly skipped scenarios). Per
playbook trap #22 the lint script drops --deny-warnings.
Verified locally: format clean, lint 0/28, typecheck clean,
test 340/342 (2 pre-existing skipped), actionlint clean across all
12 workflows.
* ci(unity-builder): fix Tests + Plugin Architecture Health on quality-tightening
Three issues surfaced in CI after the jest -> vitest port:
1. **Obsolete snapshot blocks Tests job.**
src/model/__snapshots__/versioning.test.ts.snap had two entries
for the same 'throws for invalid strategy' assertion: one in the
vitest format ('Versioning > determineBuildVersion > ...') and one
in the legacy jest format without the '>'. vitest correctly
regenerates the new one and flags the old one as obsolete; CI
runs without --update so 'Test Files 1 failed' even though all
343 tests passed. Removed the obsolete entry.
2. **'Plugin Architecture Health' workflow still calls jest.**
.github/workflows/validate-orchestrator.yml had two 'npx jest'
steps (orchestrator-plugin unit tests + orchestrator-standalone
tests). The unity-builder + orchestrator codebases are both on
vitest now. Replaced both with 'yarn vitest run'.
3. **jest-fail-on-console + src/jest.setup.ts left over.**
The earlier vitest port missed the jest-fail-on-console
integration. yarn install in CI surfaced
YN0002: doesn't provide @jest/globals (requested by
jest-fail-on-console). Removed jest-fail-on-console + jest.setup.ts;
added src/test/setup.ts with the equivalent vitest beforeEach
spies (same as unity-test-runner).
---------
Co-authored-by: frostebite <jas.f.ukcmti@gmail.com>
120 lines
4.0 KiB
TypeScript
120 lines
4.0 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach, beforeAll, afterAll, test } from 'vitest';
|
|
import ImageTag from './image-tag';
|
|
|
|
describe('ImageTag', () => {
|
|
const testImageParameters = {
|
|
editorVersion: '2099.9.9f9',
|
|
targetPlatform: 'Test',
|
|
builderPlatform: '',
|
|
containerRegistryRepository: 'unityci/editor',
|
|
containerRegistryImageVersion: '3',
|
|
};
|
|
|
|
const defaults = {
|
|
image: 'unityci/editor',
|
|
};
|
|
|
|
describe('constructor', () => {
|
|
it('can be called', () => {
|
|
expect(() => new ImageTag(testImageParameters)).not.toThrow();
|
|
});
|
|
|
|
it('accepts parameters and sets the right properties', () => {
|
|
const image = new ImageTag(testImageParameters);
|
|
|
|
expect(image.repository).toStrictEqual('unityci/editor');
|
|
expect(image.editorVersion).toStrictEqual(testImageParameters.editorVersion);
|
|
expect(image.targetPlatform).toStrictEqual(testImageParameters.targetPlatform);
|
|
expect(image.builderPlatform).toStrictEqual(testImageParameters.builderPlatform);
|
|
});
|
|
|
|
test.each(['2000.0.0f0', '2011.1.11f1', '6000.0.0f1'])(
|
|
'accepts %p version format',
|
|
(version) => {
|
|
expect(
|
|
() =>
|
|
new ImageTag({
|
|
editorVersion: version,
|
|
targetPlatform: testImageParameters.targetPlatform,
|
|
}),
|
|
).not.toThrow();
|
|
},
|
|
);
|
|
|
|
test.each(['some version', ''])('throws for incorrect version %p', (editorVersion) => {
|
|
const { targetPlatform } = testImageParameters;
|
|
expect(() => new ImageTag({ editorVersion, targetPlatform })).toThrow();
|
|
});
|
|
|
|
test.each(['nonExisting'])('throws for unsupported target %p', (targetPlatform) => {
|
|
expect(() => new ImageTag({ targetPlatform })).toThrow();
|
|
});
|
|
});
|
|
|
|
describe('toString', () => {
|
|
it('returns the correct version', () => {
|
|
const image = new ImageTag({
|
|
editorVersion: '2099.1.1111f1',
|
|
targetPlatform: testImageParameters.targetPlatform,
|
|
containerRegistryRepository: 'unityci/editor',
|
|
containerRegistryImageVersion: '3',
|
|
});
|
|
switch (process.platform) {
|
|
case 'win32':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:windows-2099.1.1111f1-3`);
|
|
break;
|
|
case 'linux':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:ubuntu-2099.1.1111f1-3`);
|
|
break;
|
|
}
|
|
});
|
|
it('returns customImage if given', () => {
|
|
const image = new ImageTag({
|
|
editorVersion: '2099.1.1111f1',
|
|
targetPlatform: testImageParameters.targetPlatform,
|
|
customImage: `${defaults.image}:2099.1.1111@347598437689743986`,
|
|
containerRegistryRepository: 'unityci/editor',
|
|
containerRegistryImageVersion: '3',
|
|
});
|
|
|
|
expect(image.toString()).toStrictEqual(image.customImage);
|
|
});
|
|
|
|
it('returns the specific build platform', () => {
|
|
const image = new ImageTag({
|
|
editorVersion: '2019.2.11f1',
|
|
targetPlatform: 'WebGL',
|
|
containerRegistryRepository: 'unityci/editor',
|
|
containerRegistryImageVersion: '3',
|
|
});
|
|
|
|
switch (process.platform) {
|
|
case 'win32':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:windows-2019.2.11f1-webgl-3`);
|
|
break;
|
|
case 'linux':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:ubuntu-2019.2.11f1-webgl-3`);
|
|
break;
|
|
}
|
|
});
|
|
|
|
it('returns no specific build platform for generic targetPlatforms', () => {
|
|
const image = new ImageTag({
|
|
editorVersion: '2019.2.11f1',
|
|
targetPlatform: 'NoTarget',
|
|
containerRegistryRepository: 'unityci/editor',
|
|
containerRegistryImageVersion: '3',
|
|
});
|
|
|
|
switch (process.platform) {
|
|
case 'win32':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:windows-2019.2.11f1-3`);
|
|
break;
|
|
case 'linux':
|
|
expect(image.toString()).toStrictEqual(`${defaults.image}:ubuntu-2019.2.11f1-3`);
|
|
break;
|
|
}
|
|
});
|
|
});
|
|
});
|