mirror of
https://github.com/game-ci/unity-builder.git
synced 2026-05-31 13:56:13 -07:00
16c5c20793
* chore: quality-tightening (oxfmt + oxlint + tsc + vitest + husky + actionlint)
Standard rollout for unity-builder. Most of the work was porting 24
test files from jest 27 to vitest 4.
- prettier -> oxfmt
- eslint (with @typescript-eslint, github, jest, prettier, unicorn) ->
oxlint with eslint-plugin-unicorn
- jest 27 + jest-circus + ts-jest + @types/jest + @jest/globals ->
vitest 4 + vite 7 + @vitest/coverage-istanbul (jest config files
removed)
- new: tsgo --noEmit (alongside tsc fallback)
- lefthook (and lefthook.yml) -> husky 9 with the standard
scripts/ensure-husky.mjs self-heal pattern + lint-staged
- new: gitleaks, actionlint, shellcheck as mise-managed binaries
- TypeScript bumped target ES2020 -> ES2022 + lib ES2022 + DOM (for
Error.cause and modern globals)
Test migration (24 files):
- Bulk-converted jest.* -> vi.*; jest.Mocked -> Mocked from vitest;
jest.MockedFunction -> MockedFunction.
- Added vitest imports to all *.test.ts files (and __mocks__/*.ts)
that didn't have them.
- src/index.ts: extracted runMain() as a named export and gated the
module-level invocation behind NODE_ENV !== 'test'. The
index-plugin-features test now calls runMain() directly instead of
relying on jest's removed vi.isolateModules.
- index-plugin-features.test.ts: moved hoisted refs (mockPlugin,
mockLoadOrchestratorPlugin) into vi.hoisted() so vi.mock factories
can reference them. Replaced arrow constructor mock for ImageTag
with regular function() {...} (vitest 4 disallows arrows as ctors).
Replaced require('./model') / require('@actions/core') inside test
bodies with top-level imports.
- model/orchestrator-plugin.test.ts: dropped jest's '{ virtual: true }'
flag (vitest doesn't support it); replaced the
'mock factory throws' pattern with 'createPlugin throws' so vitest
doesn't wrap the error message at the assertion site.
- model/versioning.test.ts: stray jest.spyOn -> vi.spyOn; replaced
mockImplementation() with no args (jest pattern) by
mockResolvedValue('') / mockImplementation(() => undefined) where
the source expects a string return.
Workflow shell-quoting cleanup (actionlint):
- All bare $GITHUB_STEP_SUMMARY / $GITHUB_OUTPUT / $GITHUB_ENV
redirects quoted across 2 workflows (SC2086).
- s3://$AWS_STACK_NAME / s3://$BUCKET_NAME -> s3://"$AWS_STACK_NAME"
/ s3://"$BUCKET_NAME".
- 'for i in {1..N}; do ... done' loops where i isn't referenced in
the body renamed to 'for _ in' (SC2034).
- 'grep ... | wc -l' -> 'grep -c ...' (SC2126).
- Multiple consecutive '>> $file' redirects in
validate-community-plugins.yml summary block collapsed into a
single block redirect (SC2129).
- 'cat $file | python3 -c "..."' -> 'python3 -c "..." < $file'
(SC2002).
- http://${VAR}:port -> http://"${VAR}":port (SC2086).
tsgo: kept tsc --noEmit as the default 'typecheck' because
unity-builder publishes CommonJS for the GitHub Action consumer,
which conflicts with tsgo's bundler/node16 moduleResolution
requirement (per playbook trap #9). 'yarn typecheck:tsgo' is wired
up for when consumers move to ESM.
Caveats: 28 pre-existing oxlint warnings remain (mostly
typescript/no-explicit-any across the build-parameter shapes and
vitest/no-disabled-tests on 2 explicitly skipped scenarios). Per
playbook trap #22 the lint script drops --deny-warnings.
Verified locally: format clean, lint 0/28, typecheck clean,
test 340/342 (2 pre-existing skipped), actionlint clean across all
12 workflows.
* ci(unity-builder): fix Tests + Plugin Architecture Health on quality-tightening
Three issues surfaced in CI after the jest -> vitest port:
1. **Obsolete snapshot blocks Tests job.**
src/model/__snapshots__/versioning.test.ts.snap had two entries
for the same 'throws for invalid strategy' assertion: one in the
vitest format ('Versioning > determineBuildVersion > ...') and one
in the legacy jest format without the '>'. vitest correctly
regenerates the new one and flags the old one as obsolete; CI
runs without --update so 'Test Files 1 failed' even though all
343 tests passed. Removed the obsolete entry.
2. **'Plugin Architecture Health' workflow still calls jest.**
.github/workflows/validate-orchestrator.yml had two 'npx jest'
steps (orchestrator-plugin unit tests + orchestrator-standalone
tests). The unity-builder + orchestrator codebases are both on
vitest now. Replaced both with 'yarn vitest run'.
3. **jest-fail-on-console + src/jest.setup.ts left over.**
The earlier vitest port missed the jest-fail-on-console
integration. yarn install in CI surfaced
YN0002: doesn't provide @jest/globals (requested by
jest-fail-on-console). Removed jest-fail-on-console + jest.setup.ts;
added src/test/setup.ts with the equivalent vitest beforeEach
spies (same as unity-test-runner).
---------
Co-authored-by: frostebite <jas.f.ukcmti@gmail.com>
77 lines
2.1 KiB
JSON
77 lines
2.1 KiB
JSON
{
|
|
"name": "unity-builder",
|
|
"version": "3.0.0",
|
|
"description": "Build Unity projects for different platforms.",
|
|
"main": "dist/index.js",
|
|
"repository": "git@github.com:game-ci/unity-builder.git",
|
|
"author": "Webber <webber@takken.io>",
|
|
"license": "MIT",
|
|
"scripts": {
|
|
"prepare": "husky",
|
|
"build": "yarn && tsc && ncc build lib --source-map --license licenses.txt",
|
|
"test": "node scripts/ensure-husky.mjs && vitest run",
|
|
"test:watch": "vitest",
|
|
"test:ci": "vitest run",
|
|
"coverage": "vitest run --coverage",
|
|
"lint": "yarn oxlint --report-unused-disable-directives",
|
|
"format": "oxfmt --write",
|
|
"format:check": "oxfmt --check",
|
|
"typecheck": "tsc --noEmit",
|
|
"typecheck:tsgo": "tsgo --noEmit",
|
|
"setup:hooks": "node scripts/ensure-husky.mjs"
|
|
},
|
|
"lint-staged": {
|
|
"*.@(ts|tsx|mts|js|jsx|mjs|cjs)": [
|
|
"oxlint --fix --quiet",
|
|
"oxfmt --write"
|
|
],
|
|
"*.@(json|jsonc|json5|md|mdx|yaml|yml|css|scss|sass|html|toml)": "oxfmt --write",
|
|
".github/workflows/*.@(yml|yaml)": "actionlint"
|
|
},
|
|
"engines": {
|
|
"node": ">=18.x"
|
|
},
|
|
"dependencies": {
|
|
"@actions/cache": "^4.0.0",
|
|
"@actions/core": "^1.11.1",
|
|
"@actions/exec": "^1.1.1",
|
|
"@actions/github": "^6.0.0",
|
|
"commander": "^9.0.0",
|
|
"commander-ts": "^0.2.0",
|
|
"md5": "^2.3.0",
|
|
"nanoid": "^3.3.1",
|
|
"reflect-metadata": "^0.1.13",
|
|
"semver": "^7.5.2",
|
|
"ts-md5": "^1.3.1",
|
|
"unity-changeset": "^3.1.0",
|
|
"yaml": "^2.2.2"
|
|
},
|
|
"devDependencies": {
|
|
"@types/node": "^17.0.23",
|
|
"@types/semver": "^7.3.9",
|
|
"@typescript/native-preview": "^7.0.0-dev.20260505.1",
|
|
"@vercel/ncc": "^0.36.1",
|
|
"@vitest/coverage-istanbul": "^4.1.5",
|
|
"cross-env": "^7.0.3",
|
|
"eslint": "^10.3.0",
|
|
"eslint-plugin-unicorn": "^64.0.0",
|
|
"husky": "9",
|
|
"js-yaml": "^4.1.0",
|
|
"lint-staged": "^16.4.0",
|
|
"node-fetch": "2",
|
|
"oxfmt": "^0.48.0",
|
|
"oxlint": "^1.63.0",
|
|
"ts-node": "10.8.1",
|
|
"typescript": "4.7.4",
|
|
"vite": "^7",
|
|
"vitest": "^4",
|
|
"yarn-audit-fix": "^9.3.8"
|
|
},
|
|
"packageManager": "yarn@4.14.1",
|
|
"dependenciesMeta": {
|
|
"lefthook": {
|
|
"built": true
|
|
}
|
|
}
|
|
}
|