mirror of
https://github.com/game-ci/unity-builder.git
synced 2026-09-29 12:07:05 -07:00
chore: rebuild dist for #847's unityVersion -> --engineVersion mapping
dist/index.js (the action's actual compiled entrypoint per action.yml's main: dist/index.js) was never rebuilt when #847 changed src/build-args.ts and src/index.ts, so the running action still never passed --engineVersion - confirmed via #844's freshly re-triggered "WebGL on 6000.0.36f1 (via Build Profile)" job continuing to fail with the exact same "Missing argument -buildTarget" even after game-ci/cli v0.1.17 shipped the CLI-side fix (#154).
This commit is contained in:
+14
-14
@@ -10,18 +10,20 @@ require('./sourcemap-register.js');/******/ (() => { // webpackBootstrap
|
|||||||
* Translates unity-builder's action inputs into `game-ci build` (or, for
|
* Translates unity-builder's action inputs into `game-ci build` (or, for
|
||||||
* providerStrategy=local-system, `game-ci orchestrate`) CLI flags.
|
* providerStrategy=local-system, `game-ci orchestrate`) CLI flags.
|
||||||
*
|
*
|
||||||
* Two deliberate omissions for the `build` path, both because there is
|
* One deliberate omission for the `build` path, because there is nothing
|
||||||
* nothing to translate to:
|
* to translate to:
|
||||||
* - `unityVersion` (except "auto"): the CLI always detects the Unity
|
|
||||||
* version from the checked-out project's ProjectSettings/ProjectVersion.txt
|
|
||||||
* and has no flag to override that today (game-ci/cli's engine-detection
|
|
||||||
* middleware unconditionally overwrites any passed value). Pinning a
|
|
||||||
* version other than "auto" is a known, real gap versus the original
|
|
||||||
* action - see the PR this shipped in.
|
|
||||||
* - `providerStrategy` values other than "local"/"local-system": the base
|
* - `providerStrategy` values other than "local"/"local-system": the base
|
||||||
* action (without the separately-installed @game-ci/orchestrator plugin)
|
* action (without the separately-installed @game-ci/orchestrator plugin)
|
||||||
* already throws for these today, so throwing here isn't a regression.
|
* already throws for these today, so throwing here isn't a regression.
|
||||||
*
|
*
|
||||||
|
* `unityVersion` (except "auto", which means "let the CLI auto-detect from
|
||||||
|
* ProjectSettings/ProjectVersion.txt", so it's never passed through as a
|
||||||
|
* literal flag value): mapped to `--engineVersion`, which game-ci/cli's
|
||||||
|
* engine-detection middleware now respects instead of unconditionally
|
||||||
|
* overwriting (game-ci/cli#154). Not carried into ORCHESTRATE_STRING_FLAGS -
|
||||||
|
* unverified whether `orchestrate`'s local-system path reads engineVersion
|
||||||
|
* the same way; scope this out until confirmed.
|
||||||
|
*
|
||||||
* Boolean inputs use GitHub Actions' own truthy/falsy string convention
|
* Boolean inputs use GitHub Actions' own truthy/falsy string convention
|
||||||
* ('true'/'false', case-insensitive) - see actions/toolkit's getBooleanInput.
|
* ('true'/'false', case-insensitive) - see actions/toolkit's getBooleanInput.
|
||||||
*/
|
*/
|
||||||
@@ -217,6 +219,10 @@ function buildCliArgs({ getInput }) {
|
|||||||
throw new Error('targetPlatform is required.');
|
throw new Error('targetPlatform is required.');
|
||||||
}
|
}
|
||||||
args.push(`--targetPlatform=${targetPlatform}`);
|
args.push(`--targetPlatform=${targetPlatform}`);
|
||||||
|
const unityVersion = getInput('unityVersion');
|
||||||
|
if (unityVersion && unityVersion !== 'auto') {
|
||||||
|
args.push(`--engineVersion=${unityVersion}`);
|
||||||
|
}
|
||||||
pushStringFlags(args, getInput, STRING_FLAGS);
|
pushStringFlags(args, getInput, STRING_FLAGS);
|
||||||
pushBooleanFlags(args, getInput, BOOLEAN_FLAGS);
|
pushBooleanFlags(args, getInput, BOOLEAN_FLAGS);
|
||||||
return args;
|
return args;
|
||||||
@@ -461,12 +467,6 @@ const download_cli_1 = __nccwpck_require__(3431);
|
|||||||
const resolve_project_path_1 = __nccwpck_require__(2833);
|
const resolve_project_path_1 = __nccwpck_require__(2833);
|
||||||
async function run() {
|
async function run() {
|
||||||
try {
|
try {
|
||||||
const unityVersion = core.getInput('unityVersion') || 'auto';
|
|
||||||
if (unityVersion !== 'auto') {
|
|
||||||
core.warning(`unityVersion="${unityVersion}" is ignored: the underlying game-ci CLI always detects the Unity ` +
|
|
||||||
"version from the checked-out project's ProjectSettings/ProjectVersion.txt and has no flag to " +
|
|
||||||
'override it yet.');
|
|
||||||
}
|
|
||||||
const cliVersion = core.getInput('cliVersion') || 'latest';
|
const cliVersion = core.getInput('cliVersion') || 'latest';
|
||||||
const cliPath = await (0, download_cli_1.downloadCli)(cliVersion);
|
const cliPath = await (0, download_cli_1.downloadCli)(cliVersion);
|
||||||
const projectPath = (0, resolve_project_path_1.resolveProjectPath)({
|
const projectPath = (0, resolve_project_path_1.resolveProjectPath)({
|
||||||
|
|||||||
+1
-1
File diff suppressed because one or more lines are too long
Reference in New Issue
Block a user