pr feedback

2026-06-13 17:33:54 -07:00 · 2025-12-15 20:17:20 +00:00
parent be6f2f058a
commit 5ff53ae347
4 changed files with 35 additions and 11 deletions
@@ -5574,9 +5574,16 @@ class Caching {
                        catch {
                            // Ignore parsing errors
                        }
-                        // If disk is still at 100% after cleanup, skip tar operation to prevent hang
+                        // If disk is still at 100% after cleanup, skip tar operation to prevent hang.
+                        // Do NOT fail the build here – it's better to skip caching than to fail the job
+                        // due to shared CI disk pressure.
                        if (diskUsageAfterCleanup >= 100) {
-                            throw new Error(`Cannot create cache archive: disk is still at ${diskUsageAfterCleanup}% after cleanup. Tar operation would hang. Please free up disk space manually.`);
+                            const message = `Cannot create cache archive: disk is still at ${diskUsageAfterCleanup}% after cleanup. Tar operation would hang. Skipping cache push; please free up disk space manually if this persists.`;
+                            cloud_runner_logger_1.default.logWarning(message);
+                            remote_client_logger_1.RemoteClientLogger.log(message);
+                            // Restore working directory before early return
+                            process.chdir(`${startPath}`);
+                            return;
                        }
                    }
                }