mirror of
https://github.com/game-ci/unity-builder.git
synced 2026-06-18 14:06:50 -07:00
pr feedback
This commit is contained in:
@@ -81,7 +81,9 @@ class KubernetesTaskRunner {
|
|||||||
errorMessage.toLowerCase().includes('unable to retrieve container logs');
|
errorMessage.toLowerCase().includes('unable to retrieve container logs');
|
||||||
|
|
||||||
if (isKubectlLogsError) {
|
if (isKubectlLogsError) {
|
||||||
CloudRunnerLogger.log(`Kubectl unable to retrieve logs, attempt ${kubectlLogsFailedCount}/${maxKubectlLogsFailures}`);
|
CloudRunnerLogger.log(
|
||||||
|
`Kubectl unable to retrieve logs, attempt ${kubectlLogsFailedCount}/${maxKubectlLogsFailures}`,
|
||||||
|
);
|
||||||
|
|
||||||
// If kubectl logs has failed multiple times, try reading the log file directly from the pod
|
// If kubectl logs has failed multiple times, try reading the log file directly from the pod
|
||||||
// This works even if the pod is terminated, as long as it hasn't been deleted
|
// This works even if the pod is terminated, as long as it hasn't been deleted
|
||||||
@@ -271,9 +273,7 @@ class KubernetesTaskRunner {
|
|||||||
// These errors can be added via stderr even when kubectl fails
|
// These errors can be added via stderr even when kubectl fails
|
||||||
// We filter them out so they don't pollute the BuildResults
|
// We filter them out so they don't pollute the BuildResults
|
||||||
const lines = output.split('\n');
|
const lines = output.split('\n');
|
||||||
const filteredLines = lines.filter(
|
const filteredLines = lines.filter((line) => !line.toLowerCase().includes('unable to retrieve container logs'));
|
||||||
(line) => !line.toLowerCase().includes('unable to retrieve container logs'),
|
|
||||||
);
|
|
||||||
const filteredOutput = filteredLines.join('\n');
|
const filteredOutput = filteredLines.join('\n');
|
||||||
|
|
||||||
// Log if we filtered out significant content
|
// Log if we filtered out significant content
|
||||||
|
|||||||
Reference in New Issue
Block a user