fix: k3d/LocalStack networking - use shared Docker network and container name

dist/index.js

@@ -2136,6 +2136,36 @@ const cloud_runner_options_1 = __importDefault(__nccwpck_require__(66965));
 const github_1 = __importDefault(__nccwpck_require__(83654));
 const aws_client_factory_1 = __nccwpck_require__(30161);
 class AWSTaskRunner {
+    /**
+     * Transform localhost endpoints to host.docker.internal for container environments.
+     * When LocalStack is used, ECS tasks run in Docker containers that need to reach
+     * LocalStack on the host machine via host.docker.internal.
+     */
+    static transformEndpointsForContainer(environment) {
+        const endpointEnvironmentNames = new Set([
+            'AWS_S3_ENDPOINT',
+            'AWS_ENDPOINT',
+            'AWS_CLOUD_FORMATION_ENDPOINT',
+            'AWS_ECS_ENDPOINT',
+            'AWS_KINESIS_ENDPOINT',
+            'AWS_CLOUD_WATCH_LOGS_ENDPOINT',
+            'INPUT_AWSS3ENDPOINT',
+            'INPUT_AWSENDPOINT',
+        ]);
+        return environment.map((x) => {
+            let value = x.value;
+            if (typeof value === 'string' &&
+                endpointEnvironmentNames.has(x.name) &&
+                (value.startsWith('http://localhost') || value.startsWith('http://127.0.0.1'))) {
+                // Replace localhost with host.docker.internal so ECS containers can access host services
+                value = value
+                    .replace('http://localhost', 'http://host.docker.internal')
+                    .replace('http://127.0.0.1', 'http://host.docker.internal');
+                cloud_runner_logger_1.default.log(`AWS TaskRunner: Replaced localhost with host.docker.internal for ${x.name}: ${value}`);
+            }
+            return { name: x.name, value };
+        });
+    }
     static async runTask(taskDef, environment, commands) {
         const cluster = taskDef.baseResources?.find((x) => x.LogicalResourceId === 'ECSCluster')?.PhysicalResourceId || '';
         const taskDefinition = taskDef.taskDefResources?.find((x) => x.LogicalResourceId === 'TaskDefinition')?.PhysicalResourceId || '';
@@ -2143,6 +2173,8 @@ class AWSTaskRunner {
         const SubnetTwo = taskDef.baseResources?.find((x) => x.LogicalResourceId === 'PublicSubnetTwo')?.PhysicalResourceId || '';
         const ContainerSecurityGroup = taskDef.baseResources?.find((x) => x.LogicalResourceId === 'ContainerSecurityGroup')?.PhysicalResourceId || '';
         const streamName = taskDef.taskDefResources?.find((x) => x.LogicalResourceId === 'KinesisStream')?.PhysicalResourceId || '';
+        // Transform localhost endpoints for container environment
+        const transformedEnvironment = AWSTaskRunner.transformEndpointsForContainer(environment);
         const runParameters = {
             cluster,
             taskDefinition,
@@ -2151,7 +2183,7 @@ class AWSTaskRunner {
                 containerOverrides: [
                     {
                         name: taskDef.taskDefStackName,
-                        environment,
+                        environment: transformedEnvironment,
                         command: ['-c', command_hook_service_1.CommandHookService.ApplyHooksToCommands(commands, cloud_runner_1.default.buildParameters)],
                     },
                 ],
@@ -4041,6 +4073,7 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 const client_node_1 = __nccwpck_require__(89679);
 const command_hook_service_1 = __nccwpck_require__(96159);
 const cloud_runner_1 = __importDefault(__nccwpck_require__(79144));
+const cloud_runner_logger_1 = __importDefault(__nccwpck_require__(42864));
 class KubernetesJobSpecFactory {
     static getJobSpec(command, image, mountdir, workingDirectory, environment, secrets, buildGuid, buildParameters, secretName, pvcName, jobName, k8s, containerName, ip = '') {
         const endpointEnvironmentNames = new Set([
@@ -4053,16 +4086,21 @@ class KubernetesJobSpecFactory {
             'INPUT_AWSS3ENDPOINT',
             'INPUT_AWSENDPOINT',
         ]);
+        // Determine the LocalStack hostname to use for K8s pods
+        // Priority: LOCALSTACK_HOST env var > localstack-main (container name on shared network)
+        const localstackHost = process.env['LOCALSTACK_HOST'] || 'localstack-main';
+        cloud_runner_logger_1.default.log(`K8s pods will use LocalStack host: ${localstackHost}`);
         const adjustedEnvironment = environment.map((x) => {
             let value = x.value;
             if (typeof value === 'string' &&
                 endpointEnvironmentNames.has(x.name) &&
                 (value.startsWith('http://localhost') || value.startsWith('http://127.0.0.1'))) {
-                // Replace localhost with host.k3d.internal so pods can access host services
-                // This simulates accessing external services (like real AWS S3)
+                // Replace localhost with the LocalStack container hostname
+                // When k3d and LocalStack are on the same Docker network, pods can reach LocalStack by container name
                 value = value
-                    .replace('http://localhost', 'http://host.k3d.internal')
-                    .replace('http://127.0.0.1', 'http://host.k3d.internal');
+                    .replace('http://localhost', `http://${localstackHost}`)
+                    .replace('http://127.0.0.1', `http://${localstackHost}`);
+                cloud_runner_logger_1.default.log(`Replaced localhost with ${localstackHost} for ${x.name}: ${value}`);
             }
             return { name: x.name, value };
         });