game-ci/unity-builder
1
0
Fork 0
mirror of https://github.com/game-ci/unity-builder.git synced 2026-06-13 17:33:54 -07:00
Code Issues Packages Projects Releases Wiki Activity

Pass Android parameters for Windows builds, fixes #434 (#436)

Browse Source 
https://github.com/game-ci/unity-builder/issues/434 will show that no Windows builds are currently capable of sending `androidVersionCode` or any other Android parameters. This can be fixed very simply by adjusting the build script to pass these parameters. Compare the following two files:

- https://github.com/game-ci/unity-builder/blob/cdee7d1d9a8ab9eccc408a37832b43d6afa73507/dist/platforms/windows/build.ps1#L112
- https://github.com/game-ci/unity-builder/blob/cdee7d1d9a8ab9eccc408a37832b43d6afa73507/dist/platforms/ubuntu/steps/build.sh#L138

It's clear that the current Windows build script is omitting certain parameters. This will resolve that issue (linked in commit message header).
This commit is contained in:
Shane Engelman
2022-09-16 13:12:28 -07:00
committed by GitHub
parent cdee7d1d9a
commit 1adfabf512
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dist/platforms/windows/build.ps1
Vendored
+6
View File
@@ -116,6 +116,12 @@ Write-Output ""
-customBuildTarget $Env:BUILD_TARGET `
-customBuildPath $Env:CUSTOM_BUILD_PATH `
-buildVersion $Env:VERSION `
-androidVersionCode $Env:ANDROID_VERSION_CODE `
-androidKeystoreName $Env:ANDROID_KEYSTORE_NAME `
-androidKeystorePass $Env:ANDROID_KEYSTORE_PASS `
-androidKeyaliasName $Env:ANDROID_KEYALIAS_NAME `
-androidKeyaliasPass $Env:ANDROID_KEYALIAS_PASS `
-androidTargetSdkVersion $Env:ANDROID_TARGET_SDK_VERSION `
$Env:CUSTOM_PARAMETERS `
-logfile | Out-Host